Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Location/Time: Z115, 14:30

...

ItemDescriptionActions/ decisions
Review of last meeting2016-10-13+MercuryDPM+Meeting

 

Tools directoryIt would be useful if a tools directory could be created in the trunk, for example for merging the files produced by the parallel code.

what should go in

  •  Anthony Thornton will merge Tools into Trunk: Deadline:  or Whisky

 

Major bug checkParticleForInterachtion

code-snippet:

bool DPMBase::checkParticleForInteraction(const BaseParticle& p)
{
//Check if it has no collision with walls
  for (BaseWall* w : wallHandler)
{ ... }
//Check if it has no collision with other particles
  for (BaseParticle* p : particleHandler)
{ ... }

}

The second p overwrites the input parameter, the particle we want to check interactions for is not visible in this loop.

Almost all driver codes use this method, so fixing this might give different results for everyone.

This method is overwritten by MercuryBase, which uses hGridHasParticleContacts to check if the given particle is in interaction with another particle.

Both trunk and alpha are affected.

ParallelMarnix now has a fully working domain decomposition.

Marnix' parallel code works now.

How to make it accessible to Kim

MaserIrana Denissen has the maser mostly working, but still a few bugs to work out 
Next meeting  14:30

Actions:

  •   Anthony Thornton will create a branch for Kim Kose with parallel functionalities.